Repository navigation
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b5c76ef. Configure here.
Buyers prove GetTradeOffer when their view diverges from CSFloat's offer state; either party proves when a trade waits on a cancel ping. Gated by the offer_state notary meta flag. Ref CSF-1979
…d cancel ping; batch GetTradeOffers unfiltered
…tch fails instead of refetching
…ays telemetry pings
… already cover the rest
…ing wait covers it
…ailure cooldown like other provers
Step7750
force-pushed
the
feat/csf-1979-notary-offer-state
branch
from
October 14, 2026 04:30
b5c76ef to
94aa8ca
Compare
Collaborator
Author
|
@GODrums Apologies for the delay, this should now be ready to review! |
…tary meta for 30 minutes
GODrums
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetTradeOffer(s)proof for pending trades when the offer state they see on Steam differs from CSFloat's, or the trade is waiting on a cancel ping. Lets the offer state update from verified data when the seller is offline.GetTradeOffersfetch; runs after other telemetry and shares the background notary failure cooldown.offer_statenotary meta flag.Ref CSF-1979
Note
Medium Risk
Changes trade lifecycle ordering and trusted state updates for pending offers; mistakes could mis-report cancellations or offer state, though feature flags, age gates, and shared failure cooldown limit blast radius.
Overview
Adds buyer-side background notary proofs so CSFloat can refresh Steam trade offer state from verified
GetTradeOffer(s)data when what the buyer sees on Steam disagrees with the server, or when a trade is waiting on a cancel ping and the offer is no longer active. Proving is gated by the newoffer_statenotary meta flag, skips offers changed in the last 5 minutes (seller ping first) and accepted offers, and batches multiple candidates into one received-offers proof.The trade-status alarm now fetches sent/received offers once per run and passes that snapshot into sent-offer pings, cancel pings, and offer-state proving. Offer-state proving runs after other telemetry but before cancel pings so notarized state lands before the untrusted “offer is gone” signal.
Notary plumbing is refactored:
submitNotaryProofis shared, notary meta is cached for 30 minutes (failed fetches are not cached), andSteamOffergains optionalupdated_at/notarized_atfields for timing decisions.Reviewed by Cursor Bugbot for commit ab0a921. Bugbot is set up for automated code reviews on this repo. Configure here.